Feature branch blob proof #3985
Conversation
vgonkivs
added
kind:break!
vgonkivs
requested review from
renaynay,
Wondertan,
walldiss and
cristaloleg
as code owners
|
|
…3610) Co-authored-by: rene <[email protected]>
Closes #3629 Co-authored-by: Hlib Kanunnikov <[email protected]>
vgonkivs
force-pushed
the
feature_branch_blob_proof
branch
from
f9a3187 to
29dcf79
Compare
|
|
vgonkivs
force-pushed
the
feature_branch_blob_proof
branch
from
29dcf79 to
664255c
Compare
| @@ -6,54 +6,162 @@ import ( | |||
| "errors" | |||
| "fmt" | |||
|
|
|||
| "github.com/tendermint/tendermint/crypto/merkle" | |||
There was a problem hiding this comment.
Looks like it should be "github.com/celestiaorg/go-square/merkle" 😉
There was a problem hiding this comment.
Hm, I see that in go.mod github.com/celestiaorg/go-square/merkle got removed. Also, in go-square/v2 there is no merkle package anymore. So, I might be wrong about bad import.
| return ErrInvalidProof | ||
| // Verify takes a data root and verifies if the | ||
| // provided proof's subtree roots were committed to the given data root. | ||
| func (p *Proof) Verify(dataRoot []byte) (bool, error) { |
There was a problem hiding this comment.
Do we need a bool return param at all? Looks like it's only true when error is nil.
There was a problem hiding this comment.
You are right. Double-checked and it seems we don't have a case when we have to return false, nil or true,error
| } | ||
|
|
||
| func (com Commitment) String() string { | ||
| return string(com) |
There was a problem hiding this comment.
Should it be hex or base64 ?
|
btw, given that we have this PR, can we close this one #3796? |
Yeah I think so |
Merge Blob Proof feature branch to api/breaks